Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop @babel/plugin-proposal-class-properties #17318

Closed
wants to merge 2 commits into from

Conversation

ianzone
Copy link

@ianzone ianzone commented Feb 14, 2025

这个 PR 做了什么? (简要描述所做更改)
将 @babel/plugin-proposal-class-properties 替换为 @babel/plugin-transform-class-properties

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

This was referenced Feb 15, 2025
@tutuxxx tutuxxx self-requested a review February 27, 2025 06:19
Copy link
Member

@tutuxxx tutuxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianzone 感谢贡献,有两点确认下:
1、尽量不产生代码风格相关的变更
2、corejs配置项从3改为true是为了解决什么问题

@ianzone
Copy link
Author

ianzone commented Feb 27, 2025

@ianzone 感谢贡献,有两点确认下: 1、尽量不产生代码风格相关的变更 2、corejs配置项从3改为true是为了解决什么问题

  1. 代码风格是IDE保存的时候自动格式化的
  2. 这个改错了,当时IDE显示cosejs需要一个布尔值,就把它改成了true

@ianzone
Copy link
Author

ianzone commented Feb 27, 2025

改了

@tutuxxx
Copy link
Member

tutuxxx commented Feb 27, 2025

@ianzone 代码风格相关的改动恢复一下哈,应该是你本地环境有差异导致的

@tutuxxx tutuxxx self-assigned this Feb 27, 2025
@ianzone
Copy link
Author

ianzone commented Feb 27, 2025

合并这个吧 #17385

@ianzone ianzone closed this Feb 27, 2025
@ianzone ianzone deleted the babel-update branch March 6, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants