fix(index.d.ts): 修正 Canvas 的类型定义 #2762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/taro-transformer-wx/src/render.ts # packages/taro-weapp/src/index.js
# Conflicts: # packages/taro-transformer-wx/src/index.ts # packages/taro-transformer-wx/src/render.ts
# Conflicts: # docs/wx-hybrid.md # packages/taro-transformer-wx/src/render.ts
# Conflicts: # packages/taro-transformer-wx/src/render.ts
使用 Apdater 帮助判断
因为 ifStatement 里含有 JSX 时，statement block 里的变量会被改名。所以太早处理 propsManager.set 的先验条件的话变量名会不对。
没有 props 的自定义组件没有接收 compid，之前只有 compid 属性的 observer 里 init component，因此需要在 attached 中也需要调用一次 init component
# Conflicts: # packages/taro-transformer-wx/src/render.ts
|
噗... |
|
把他删掉就是了 |
|
master 的代码回退了一次，现在这个 pr 有点问题，辛苦再提交一次吧 |
|
@luckyadam ok |
|
要重看 Pro Git 了，打 patch 关掉重来先... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 里主要是修正了 CanvasContext 的类型定义，然后补充了部分代码注释
由于我的编辑器在保存的时候还修改了部分代码的格式问题（主要是不正确的缩进），所以 review 起来可能会比较碍事… 如果需要修改的话请加 review 请求