Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: objectExpression property key'type #3932

Merged
merged 1 commit into from
Jul 25, 2019
Merged

fix: objectExpression property key'type #3932

merged 1 commit into from
Jul 25, 2019

Conversation

cangku
Copy link
Contributor

@cangku cangku commented Jul 24, 2019

这个 PR 做了什么? (简要描述所做更改)
修复如果模块中以对象表达式的形式,key 非字符的形式,编译后存在 ${key} is not defined.

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix)

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序

@yuche yuche self-requested a review July 24, 2019 06:26
@yuche yuche merged commit c6f587c into NervJS:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants