Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taro-h5): fix scroll issue in iOS when using showToast/showModal/showActionSheet #5092

Merged
merged 15 commits into from
Dec 26, 2019
Merged

fix(taro-h5): fix scroll issue in iOS when using showToast/showModal/showActionSheet #5092

merged 15 commits into from
Dec 26, 2019

Conversation

leoswing
Copy link

这个 PR 做了什么? (简要描述所做更改)

  1. 修复showModal、showToast、showActionSheet api 调用时的滚动穿透问题;提供 interactiveHelper 函数用作添加 body 的style 修改和重置
  2. 添加 showModal 的文字的居中样式支持

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

luckyadam and others added 14 commits December 11, 2019 16:30
* h5 image在unmount时取消IntersectionObserver监听

* 删除无用代码
@Littly Littly self-assigned this Dec 26, 2019
Copy link
Contributor

@Littly Littly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献~ 这个特性可以考虑给showLoading也加一下

@Littly Littly merged commit 698c057 into NervJS:master Dec 26, 2019
jiangzm pushed a commit to jiangzm/taro that referenced this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants