Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taro-cli): 修复基于taro第三方ui 组件循环依赖时打包失败 Closes #5620 #5623

Merged
merged 1 commit into from
Mar 6, 2020
Merged

fix(taro-cli): 修复基于taro第三方ui 组件循环依赖时打包失败 Closes #5620 #5623

merged 1 commit into from
Mar 6, 2020

Conversation

werfei
Copy link

@werfei werfei commented Mar 5, 2020 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)
修复基于taro第三方ui 组件循环依赖时打包失败
原因是analyzeFiles函数在递归调用时提前清空processedScriptFiles集合的问题

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@werfei werfei mentioned this pull request Mar 5, 2020
Closed
@luckyadam
Copy link
Member

Perfect!

@luckyadam luckyadam merged commit 77e11cd into NervJS:2.x Mar 6, 2020
@taro-bot taro-bot bot mentioned this pull request Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@werfei @luckyadam