Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(taro-webpack-runner): add miniCssExtractLoaderOption support #5922

Merged
merged 2 commits into from
Apr 9, 2020
Merged

feat(taro-webpack-runner): add miniCssExtractLoaderOption support #5922

merged 2 commits into from
Apr 9, 2020

Conversation

leoswing
Copy link

@leoswing leoswing commented Apr 8, 2020 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

  1. taro-webpack-runner 添加 miniCssExtractLoaderOption 的配置支持，修复从外部传入 miniCssExtractPluginOption 无法修改内部的 loader option的问题;
  2. 文档添加对应配置 h5.miniCssExtractLoaderOption 的说明；
  3. 修改ts 类型 TaroH5Config，新增 miniCssExtractLoaderOption 属性支持。

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@leoswing leoswing changed the title feat(taro-webpack-runner): add miniCssExtractLoaderOption support for mini-css-extract-plugin feat(taro-webpack-runner): add miniCssExtractLoaderOption support Apr 8, 2020
Littly
Littly approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@Littly Littly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻感谢大佬

@Littly Littly merged commit 7315bdd into NervJS:master Apr 9, 2020
jiangzm pushed a commit to jiangzm/taro that referenced this pull request Dec 7, 2020
@leoswing @jiangzm
feat(taro-webpack-runner): add miniCssExtractLoaderOption suppo… (Ner…
4c12301 
…vJS#5922)

* feat(taro-webpack-runner): add miniCssExtractLoaderOption support for mini-css-extract-plugin

* fix: fix test case when using getModule method

Co-authored-by: liangxufei <liangxufei@mucfc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Littly Littly Littly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoswing @Littly