refactor(runtime): nextTick适配小程序setData回调 #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuche
requested changes
Apr 15, 2020
| if (initRender) { | ||
| perf.stop(PAGE_INIT) | ||
| } | ||
| }) | ||
| } | ||
| }, 0) | ||
| } | ||
|
|
||
| public enqueueUpdateCallbak (cb: Function, ctx?: Record<string, any>) { |
There was a problem hiding this comment.
这个方法会在nextTick里被外部调用
|
|
||
| public enqueueUpdateCallbak (cb: Function, ctx?: Record<string, any>) { | ||
| this.updateCallbacks.push(() => { | ||
| if (cb) { |
There was a problem hiding this comment.
这个判断没有必要，因为 cb 一定是一个函数，要么就在 Taro.nextTick 那里判断。
|
|
||
| export const nextTick = (cb: Function, ctx?: Record<string, any>) => { | ||
| const hasSetDataCallbacks = ['weapp', 'swan', 'qq', 'alipay', 'tt'] | ||
| if (~hasSetDataCallbacks.indexOf(process.env.TARO_ENV || '')) { |
There was a problem hiding this comment.
这里在 env.ts 有一个更简单的判断 isBrowser，未来还会添加新的 env，先用 isBrowser 吧。
类似于这样的判断其实最好在编译时或代码代码加载后就应该求值，且只求值一次。
| if (~hasSetDataCallbacks.indexOf(process.env.TARO_ENV || '')) { | ||
| let pageElement: TaroRootElement | null = null | ||
| const router = Current.router | ||
| if (router) { |
| const path = getPath(removeLeadingSlash(router.path), router.params) | ||
| pageElement = document.getElementById<TaroRootElement>(path) | ||
| ensure(pageElement !== null, '没有找到页面实例。') | ||
| if (pageElement) { |
There was a problem hiding this comment.
如果 ensure 函数已经判断过了，这个判断就没必要了，不过我的理解是这个不应该用 ensure，应该直接判断是否为 null，如果为真，直接走 setTimeout，根据调用时机的不同还是有可能找不到 pageElement 的（例如在页面切换的时候）
20 tasks
yuche
approved these changes
Apr 16, 2020
yuche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
需求背景：
Taro.nextTick目前触发时机是js线程下一个event loop，在小程序运行环境中，这个时机不能确保视图数据渲染完成；场景：在渲染某个元素之后，需要使用Taro.createSelectorQuery()去获取元素的样式信息时，目前触发时元素可能还没渲染完成，无法准确获取；修改点：
在小程序环境且支持渲染回调下，调用
Taro.nextTick，则回调在setData渲染完成之后执行；在其他环境，则是下一个event loop;这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求:
这个 PR 涉及以下平台:
其它需要 Reviewer 或社区知晓的内容：