Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): 在config中支持添加appId配置 编译时读取并写入到pageage.config.json中 #5985

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

persist-xyz
Copy link

这个 PR 做了什么? (简要描述所做更改)

某些场景中,希望可以动态修改package.config.json中的appid参数。
所以在config/index中添加了appId参数,编译时读取并写入到pageage.config.json中

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

@luckyadam luckyadam merged commit 4f52e72 into NervJS:master Apr 15, 2020
@persist-xyz
Copy link
Author

persist-xyz commented Apr 28, 2020

这个功能可以合并到2.x分支吗? @luckyadam

jiangzm pushed a commit to jiangzm/taro that referenced this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants