Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taro-h5): 修复pageScrollTo方法滚动的实际位置与给定的目标位置不符 #6059

Merged
merged 7 commits into from
Jul 31, 2020
Merged

fix(taro-h5): 修复pageScrollTo方法滚动的实际位置与给定的目标位置不符 #6059

merged 7 commits into from
Jul 31, 2020

Conversation

GoodbyeNJN
Copy link
Contributor

@GoodbyeNJN GoodbyeNJN commented Apr 21, 2020 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)
调用Taro.pageScrollTo方法时，滚动结束后的实际位置与调用时传入的目标位置不符

这个 PR 是什么类型? (至少选择一个)

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@ZakaryCode ZakaryCode self-requested a review April 24, 2020 06:50
ZakaryCode
ZakaryCode requested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里修改之后，scrollFunc(dest) 继续放在判断外层，会导致执行一帧内重复设置滚动条位置

@taro-bot taro-bot bot mentioned this pull request Apr 25, 2020
Closed
@ZakaryCode ZakaryCode self-requested a review April 29, 2020 02:06
@luckyadam luckyadam force-pushed the 2.x branch 2 times, most recently from 0fff737 to 4723704 Compare July 9, 2020 07:12
@taro-bot2 taro-bot2 bot mentioned this pull request Jul 11, 2020
Closed
@Chen-jj Chen-jj added A-api Area - H5 API 相关 V-2 Version - 2.x labels Jul 16, 2020
@Chen-jj Chen-jj linked an issue Jul 29, 2020 that may be closed by this pull request
pageScrollTo 滚动后的实际位置与给定的目标位置不符 #6024
Closed
ZakaryCode
ZakaryCode approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献

@ZakaryCode ZakaryCode merged commit 57fafed into NervJS:2.x Jul 31, 2020
@luckyadam luckyadam mentioned this pull request Jul 31, 2020
Merged
@taro-bot2 taro-bot2 bot mentioned this pull request Aug 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
A-api Area - H5 API 相关 V-2 Version - 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pageScrollTo 滚动后的实际位置与给定的目标位置不符
4 participants
@GoodbyeNJN @ZakaryCode @Chen-jj @luckyadam