Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shared): 给 Map 组件的 setting 添加默认值, fix #6949 #7101

Merged
merged 2 commits into from
Jul 24, 2020
Merged

fix(shared): 给 Map 组件的 setting 添加默认值, fix #6949 #7101

merged 2 commits into from
Jul 24, 2020

Conversation

Chen-jj
Copy link
Contributor

@Chen-jj Chen-jj commented Jul 17, 2020

这个 PR 做了什么?

修复微信小程序使用 Map 组件时报错的问题

这个 PR 是什么类型?

这个 PR 满足以下需求:

  • 提交到 next 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@Chen-jj Chen-jj linked an issue Jul 17, 2020 that may be closed by this pull request
Taro 3.0.2 中 <Map>组件的属性参数 setting 为可选，但事实是如果不设置 setting，微信调试工具报错：Cannot read property 'layerStyle' of null #6949
Closed
@Chen-jj Chen-jj added the V-3 Version - 3.x label Jul 17, 2020
@Chen-jj Chen-jj merged commit 230a239 into next Jul 24, 2020
@Chen-jj Chen-jj deleted the fix/component-map branch July 24, 2020 06:09
@taro-bot2 taro-bot2 bot mentioned this pull request Jul 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Littly Littly Littly approved these changes

Assignees
No one assigned
Labels
V-3 Version - 3.x
Projects
None yet
Milestone
No milestone
2 participants
@Chen-jj @Littly