Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): 自定义组件的 xml 后缀应该根据当前平台指定 #7414

Merged
merged 2 commits into from
Aug 22, 2020
Merged

fix(template): 自定义组件的 xml 后缀应该根据当前平台指定 #7414

merged 2 commits into from
Aug 22, 2020

Conversation

Chen-jj
Copy link
Contributor

@Chen-jj Chen-jj commented Aug 22, 2020

这个 PR 做了什么?

自定义组件里引用的 base 模板后缀，应该根据当前平台指定。目前写死了 .wxml

这个 PR 是什么类型?

  • 错误修复(Bugfix)

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

Garfield550
Garfield550 approved these changes Aug 22, 2020
View reviewed changes
Copy link
Collaborator

@Garfield550 Garfield550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luckyadam luckyadam merged commit 77ce0fa into next Aug 22, 2020
@luckyadam luckyadam deleted the fix/template branch August 22, 2020 09:47
@taro-bot2 taro-bot2 bot mentioned this pull request Aug 29, 2020
Closed
@alejandrosuarez alejandrosuarez mentioned this pull request Dec 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield550 Garfield550 Garfield550 approved these changes

@luckyadam luckyadam luckyadam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chen-jj @luckyadam @Garfield550