Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(canvas-h5): canvas 同步 API canvasToTempFilePath 节点获取问题 #7957

Merged
merged 5 commits into from
Dec 12, 2020
Merged

fix(canvas-h5): canvas 同步 API canvasToTempFilePath 节点获取问题 #7957

merged 5 commits into from
Dec 12, 2020

Conversation

Ininit
Copy link
Contributor

@Ininit Ininit commented Nov 3, 2020

这个 PR 做了什么? (简要描述所做更改)
修复 h5 canvas 同步方法
修复 canvasToTempFilePath 节点获取

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@Ininit Ininit changed the title Hotfix/canvas h5 fix(canvas-h5): canvas 同步 API canvasToTempFilePath 节点获取问题 Nov 3, 2020
@Chen-jj Chen-jj added the V-3 Version - 3.x label Nov 3, 2020
@Chen-jj Chen-jj requested a review from ZakaryCode November 3, 2020 06:16
@luckyadam luckyadam requested a review from Chen-jj November 10, 2020 02:12
This was referenced Nov 12, 2020
Closed
Closed
@Chen-jj Chen-jj removed their request for review December 11, 2020 11:46
@taro-bot2 taro-bot2 bot mentioned this pull request Dec 12, 2020
Closed
ZakaryCode
ZakaryCode approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献

@ZakaryCode ZakaryCode merged commit 2cab013 into NervJS:next Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
V-3 Version - 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ininit @ZakaryCode @Chen-jj