Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taro-runtime): consistent window object #8105

Merged
merged 5 commits into from
Dec 11, 2020
Merged

feat(taro-runtime): consistent window object #8105

merged 5 commits into from
Dec 11, 2020

Conversation

atzcl
Copy link
Contributor

@atzcl atzcl commented Nov 23, 2020

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:
close #8021

@@ -9,10 +9,16 @@ export const window = isBrowser ? win : {
document
}

if (!isBrowser) {
Reflect.ownKeys(global).forEach(property => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reflect 并不是所有小程序框架在所有机型都兼容,这里需要修改下。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chen-jj 改用 getOwnPropertyNamesgetOwnPropertySymbols 来枚举 global 属性了

@atzcl
Copy link
Contributor Author

atzcl commented Dec 5, 2020

ci 挂了,但是应该跟这个 pr 无关

@atzcl atzcl requested a review from Chen-jj December 10, 2020 06:05
@Chen-jj
Copy link
Contributor

Chen-jj commented Dec 11, 2020

感谢贡献~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime下的window不对劲
2 participants