Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复 incrementId 调用错误;修复 customWrapper 优化失效 #8599

Merged
merged 2 commits into from
Feb 3, 2021
Merged

修复 incrementId 调用错误;修复 customWrapper 优化失效 #8599

merged 2 commits into from
Feb 3, 2021

Conversation

rogerleung0411
Copy link
Contributor

@rogerleung0411 rogerleung0411 commented Jan 28, 2021

这个 PR 做了什么? (简要描述所做更改)

  • 原本的 incrementId 每次调用均返回一个函数,eventId 处应使用 incrementId()()
  • virtualHost: true 会使 custom-wrapper 成为虚组件,导致该 (https://github.com/NervJS/taro/pull/8305/files) PR 中 packages/taro-runtime/src/dom/root.ts performUpdate 中专门为其做的优化都不生效:
const customWrapper = ctx.selectComponent(`#${customWrapperId}`) // always undefined when virtualHost: true

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

@rogerleung0411 rogerleung0411 changed the title 修复 incrementId 返回错误;修复 customWrapper 优化失效 修复 incrementId 调用;修复 customWrapper 优化失效 Jan 28, 2021
@rogerleung0411 rogerleung0411 changed the title 修复 incrementId 调用;修复 customWrapper 优化失效 修复 incrementId 调用错误;修复 customWrapper 优化失效 Jan 28, 2021
@Chen-jj Chen-jj added the V-3 Version - 3.x label Jan 28, 2021
@Chen-jj Chen-jj requested a review from luckyadam January 28, 2021 15:33
@rogerleung0411
Copy link
Contributor Author

@Chen-jj @luckyadam 大佬们能否尽快 review 一下

Copy link
Member

@luckyadam luckyadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chen-jj @luckyadam 大佬们能否尽快 review 一下

有个地方需要调整下

@@ -120,7 +120,7 @@ export class TaroRootElement extends TaroElement {
}
const updateArrLen = customWrapperUpdate.length
if (updateArrLen) {
const eventId = `${this._path}_update_${incrementId()}`
const eventId = `${this._path}_update_${incrementId()()}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里这样修改也不太对
应该在前面声明一下

const eventIncrementId = incrementId()

然后此处使用
const eventId = ${this._path}_update_${eventIncrementId()}

类似 https://github.com/NervJS/taro/blob/next/packages/taro-runtime/src/dom/node.ts#L13

Copy link
Contributor Author

@rogerleung0411 rogerleung0411 Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done~ commit squash 了一下所以 force update 了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V-3 Version - 3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants