-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
修复 incrementId 调用错误;修复 customWrapper 优化失效 #8599
Conversation
@Chen-jj @luckyadam 大佬们能否尽快 review 一下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chen-jj @luckyadam 大佬们能否尽快 review 一下
有个地方需要调整下
@@ -120,7 +120,7 @@ export class TaroRootElement extends TaroElement { | |||
} | |||
const updateArrLen = customWrapperUpdate.length | |||
if (updateArrLen) { | |||
const eventId = `${this._path}_update_${incrementId()}` | |||
const eventId = `${this._path}_update_${incrementId()()}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里这样修改也不太对
应该在前面声明一下
const eventIncrementId = incrementId()
然后此处使用
const eventId = ${this._path}_update_${eventIncrementId()}
类似 https://github.com/NervJS/taro/blob/next/packages/taro-runtime/src/dom/node.ts#L13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done~ commit squash 了一下所以 force update 了
这个 PR 做了什么? (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求:
这个 PR 涉及以下平台:
其它需要 Reviewer 或社区知晓的内容: