Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(picker): append to body #8702

Merged
merged 8 commits into from
Apr 27, 2021
Merged

fix(picker): append to body #8702

merged 8 commits into from
Apr 27, 2021

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Feb 20, 2021 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

picker 组件的蒙层和选择器渲染到 body 里面

这个 PR 是什么类型? (至少选择一个)

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@taro-bot2 taro-bot2 bot mentioned this pull request Feb 27, 2021
Closed
@taro-bot2 taro-bot2 bot mentioned this pull request Mar 6, 2021
Closed
@Chen-jj Chen-jj requested a review from ZakaryCode March 12, 2021 06:01
@Chen-jj
Copy link
Contributor

Chen-jj commented Mar 12, 2021

@SyMind 麻烦处理一下冲突哈～

@SyMind
Copy link
Member Author

SyMind commented Mar 12, 2021

@Chen-jj 合并完毕。

@Chen-jj
Copy link
Contributor

Chen-jj commented Mar 12, 2021

@SyMind 等一下 zakary 大佬有空过一下哈

ZakaryCode
ZakaryCode approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献

@ZakaryCode ZakaryCode merged commit 0a72b66 into NervJS:next Apr 27, 2021
liuchuzhang added a commit to liuchuzhang/taro that referenced this pull request Apr 27, 2021
@liuchuzhang
Revert "fix(picker): append to body (NervJS#8702)"
9faaa39 
This reverts commit 0a72b66.
@ZakaryCode ZakaryCode mentioned this pull request Apr 29, 2021
Merged
@taro-bot2 taro-bot2 bot mentioned this pull request May 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyMind @Chen-jj @ZakaryCode