Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rn-style-transformer): switch node-sass to dart-sass #9469

Merged
merged 2 commits into from
Jun 8, 2021
Merged

feat(rn-style-transformer): switch node-sass to dart-sass #9469

merged 2 commits into from
Jun 8, 2021

Conversation

shinken008
Copy link
Collaborator

这个 PR 做了什么? (简要描述所做更改)

  1. 切换 node-sass 到 dart-sass

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@shinken008 shinken008 linked an issue Jun 7, 2021 that may be closed by this pull request
在@tarojs/rn-style-transformer中将node-sass替换为dart-sass #9421
Closed
@zhiqingchen zhiqingchen self-requested a review June 7, 2021 13:57
zhiqingchen
zhiqingchen reviewed Jun 7, 2021
View reviewed changes
Copy link
Member

@zhiqingchen zhiqingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/taro-rn-style-transformer/yarn.lock
文件中，有些依赖如aproba未删除，需执行yarn bootstrap:lerna 做下更新

zhiqingchen
zhiqingchen reviewed Jun 7, 2021
View reviewed changes
packages/taro-rn-style-transformer/src/transforms/sass.ts Outdated
@@ -1,6 +1,6 @@
import fs from 'fs'
import path from 'path'
import sass, { Options } from 'node-sass' // TODO: dart-sass 支持
import sass, { Options } from 'sass' // TODO: dart-sass 支持
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO注释需删除

@shinken008
Copy link
Collaborator Author

packages/taro-rn-style-transformer/yarn.lock
文件中，有些依赖如aproba未删除，需执行yarn bootstrap:lerna 做下更新

remove 后重装了，依赖删干净了

@zhiqingchen zhiqingchen merged commit edee0b2 into NervJS:next Jun 8, 2021
@taro-bot2 taro-bot2 bot mentioned this pull request Jun 12, 2021
Closed
@zhiqingchen zhiqingchen deleted the feat/switchsass branch July 16, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqingchen zhiqingchen zhiqingchen approved these changes

@luckyadam luckyadam luckyadam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

在@tarojs/rn-style-transformer中将node-sass替换为dart-sass
3 participants
@shinken008 @luckyadam @zhiqingchen