-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): support insertAdjacentHTML #9596
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
28adf5a
feat(runtime): support insertAdjacentHTML
b2nil b654753
fix: fix lint errors
b2nil c75bc08
fix: parentNode is possibly null
b2nil 5feee9c
fix: use for loop instead of for-of to avoid compile error
b2nil bd8af89
fix: fix lint error
b2nil cc3ff13
Merge branch 'next' into feat/insertStaticContent
luckyadam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@b2nil 这里应该是
this.insertBefore(n, this.childNodes[0])
吧,但我没搞懂为什么测试能过。现在的测试运行结果:
正确的运行结果:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
尴尬,的确插错位置了。
抱歉,我没有在本地跑测试,纯粹依赖 CI 了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
仔细看了几个 PR 的 CI 测试日志,虽然 scope 里有 @tarojs/runtime, 但是都没有执行 ci 脚本的记录。
插入位置错误的地方,你看是需要我再提 PR 改,还是你直接改?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@b2nil 我这边改下哈,另外目测是因为 @tarojs/runtime 跑测试的 npm script 和 yarn test 跑的不一致。