Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

refactor for op::Result #165

Merged
merged 2 commits into from
Mar 7, 2018

Conversation

mbrookhart
Copy link
Contributor

Man, op::result is a lot of memcpy.

@mbrookhart mbrookhart requested review from Krovatkin and ashokei March 6, 2018 23:15
@ashokei
Copy link
Contributor

ashokei commented Mar 7, 2018

seeing below issue

python example/image-classification/train_mnist.py
INFO:root:start with arguments Namespace(add_stn=False, batch_size=64, disp_batches=100, dtype='float32', gc_threshold=0.5, gc_type='none', gpus=None, is_nnp=False, kv_store='device', load_epoch=None, lr=0.05, lr_factor=0.1, lr_step_epoch
s='10', model_prefix=None, mom=0.9, monitor=0, network='mlp', num_classes=10, num_epochs=20, num_examples=60000, num_layers=None, optimizer='sgd', test_io=0, top_k=0, wd=0.0001)
example/image-classification/train_mnist.py:38: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
  label = np.fromstring(flbl.read(), dtype=np.int8)  
example/image-classification/train_mnist.py:41: DeprecationWarning: The binary mode of fromstring is deprecated, as it behaves surprisingly on unicode inputs. Use frombuffer instead
  image = np.fromstring(fimg.read(), dtype=np.uint8).reshape(len(label), rows, cols)
terminate called after throwing an instance of 'std::out_of_range'
  what():  deque::_M_range_check: __n (which is 1)>= this->size() (which is 1)
fish: “python example/image-classifica…” terminated by signal SIGABRT (Abort)

Copy link
Contributor

@ashokei ashokei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be ngraph-cpp that i used, may have to retest with different version.

Copy link
Contributor

@ashokei ashokei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,. the crash is resolved in my testing.

@mbrookhart mbrookhart merged commit 11fae70 into ngraph-integration-dev Mar 7, 2018
@mbrookhart mbrookhart deleted the mbrookhart/op_result_refactor branch March 7, 2018 22:55
mbrookhart pushed a commit that referenced this pull request Mar 7, 2018
mbrookhart pushed a commit that referenced this pull request Mar 8, 2018
…or NDArray/Enable running Optimizers in nGraph" (#166)

* Revert "refactor for op::Result (#165)"

This reverts commit 11fae70.

* Revert "NGMX-379 Refactor to FComputeEx to align with MXNet's plans for NDArray/Enable running Optimizers in nGraph (#162)"

This reverts commit 1fe35c6.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants