This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Adding test to catch zero length subgraph bug #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
approved these changes
Nov 30, 2017
|
accidentally removed and re-added @mbrookhart so his checkmark doesn't show up anymore. @ransford2011 or @louisfeng can you take a quick look? |
mbrookhart
approved these changes
Nov 30, 2017
louisfeng
approved these changes
Nov 30, 2017
| auto var_node = std::make_shared<VariableNode>(test_input, "test_input"); | ||
| test_inputs.push_back(var_node); | ||
| }; | ||
|
|
||
| virtual void TearDown() {}; | ||
| virtual void TearDown(){}; |
There was a problem hiding this comment.
I'm surprised clang format removed a space in this case and kept a space in other cases.
| @@ -35,8 +35,7 @@ class NGRAPH_NODE : public ::testing::Test { | |||
| }; | |||
|
|
|||
| class NGRAPH_GRAPH : public ::testing::Test { | |||
| protected: | |||
|
|
|||
| protected: | |||
| static bool isop(NodePtr s) { return (s->type_ == NodeType::kOp); }; | |||
There was a problem hiding this comment.
For example, here it didn't touch the space. Just wondering out loud.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some diff noise in test_ngraph.h from clang-format, the pertinent change is at line 66