Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type are added to the path of update policy and update permission fix #308 #310

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

Omnia-Wahid
Copy link

Thanks for your contribution!
fixes #308

@Nerzal
Copy link
Owner

Nerzal commented Sep 30, 2021

The tests do fail with Keycloak.
Is this a change for a newer Keycloak version?

--- FAIL: Test_CreateListGetUpdateDeletePolicy (22.39s) client_test.go:355: Created Policy ID: 3795fb93-f3d9-4ecf-ba3c-d2ed67fd5954 client_test.go:4655: Created Policy: 3795fb93-f3d9-4ecf-ba3c-d2ed67fd5954 client_test.go:4671: Policies: [{ "config": { "code": "$evaluation.grant();" }, "decisionStrategy": "UNANIMOUS", "description": "Policy Description", "id": "3795fb93-f3d9-4ecf-ba3c-d2ed67fd5954", "logic": "NEGATIVE", "name": "PolicyName26389", "type": "js" }] client_test.go:4687: Policies: [{ "decisionStrategy": "UNANIMOUS", "description": "Policy Description", "id": "3795fb93-f3d9-4ecf-ba3c-d2ed67fd5954", "logic": "NEGATIVE", "name": "PolicyName26389", "type": "js", "code": "$evaluation.grant();" }] client_test.go:4706: Error Trace: client_test.go:4706 Error: Received unexpected error: 500 Internal Server Error: unknown_error Test: Test_CreateListGetUpdateDeletePolicy Messages: UpdatePolicy failed FAIL

@Omnia-Wahid
Copy link
Author

Test_CreateListGetUpdateDeletePolicy is fixed now.
yes, this change is for the keycloak version 12.0.4. @Nerzal

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #310 (a9f89a2) into main (5bf3c29) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   76.10%   76.10%           
=======================================
  Files           4        4           
  Lines        1871     1871           
=======================================
  Hits         1424     1424           
  Misses        311      311           
  Partials      136      136           
Impacted Files Coverage Δ
client.go 74.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf3c29...a9f89a2. Read the comment docs.

Copy link
Owner

@Nerzal Nerzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@Nerzal Nerzal merged commit be5eb89 into Nerzal:main Oct 7, 2021
@Nerzal
Copy link
Owner

Nerzal commented Oct 7, 2021

i have created a new release :) Tag is v9.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update policy and update permission
3 participants