Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CreateAuthenticationExecutionFlow #327

Merged
merged 3 commits into from
Feb 17, 2022

Conversation

weixiao-huang
Copy link
Contributor

Thanks for your contribution!
Hi, if there is an issue, that your PR adresses, please link it!

@weixiao-huang weixiao-huang force-pushed the feat/add-execution-flow branch from 8711112 to 7fc8c10 Compare December 8, 2021 08:51
@Nerzal
Copy link
Owner

Nerzal commented Jan 3, 2022

Hi, could you please resolve the merge conflicts?

@weixiao-huang weixiao-huang force-pushed the feat/add-execution-flow branch from 7fc8c10 to 52627eb Compare January 3, 2022 13:40
@weixiao-huang
Copy link
Contributor Author

All conflicts have been resolved

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #327 (52627eb) into main (392e397) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

❗ Current head 52627eb differs from pull request most recent head 5bc0bb5. Consider uploading reports for the commit 5bc0bb5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   76.60%   76.44%   -0.16%     
==========================================
  Files           4        4              
  Lines        1962     1966       +4     
==========================================
  Hits         1503     1503              
- Misses        319      323       +4     
  Partials      140      140              
Impacted Files Coverage Δ
client.go 74.63% <0.00%> (-0.17%) ⬇️
models.go 92.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392e397...5bc0bb5. Read the comment docs.

@Nerzal
Copy link
Owner

Nerzal commented Jan 3, 2022

Hi again :)

The code looks good so far.
Could you please also add a test for that function? :)

…xecution and CreateAuthenticationExecutionFlow
@weixiao-huang weixiao-huang force-pushed the feat/add-execution-flow branch from 9c2bc34 to c7a5419 Compare January 3, 2022 15:34
@weixiao-huang
Copy link
Contributor Author

I added tests but I cannot test it in my local machine, so please approve the test ci, thanks

client_test.go Outdated Show resolved Hide resolved
@weixiao-huang weixiao-huang force-pushed the feat/add-execution-flow branch from a81c57e to 5bc0bb5 Compare January 10, 2022 14:17
@weixiao-huang
Copy link
Contributor Author

Hello, could you please approve the ci to test?

@bastianccm
Copy link
Contributor

Hi @Nerzal can you take a look into this change? Thank you!

@Nerzal
Copy link
Owner

Nerzal commented Feb 17, 2022

LGTM thank you for the contribution!
I'll create a new Release this week, which includes all PRs i merged during the last days

@Nerzal Nerzal merged commit 08df6c5 into Nerzal:main Feb 17, 2022
@weixiao-huang weixiao-huang deleted the feat/add-execution-flow branch February 17, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants