Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ClientScope ProtocolMappers CRUD #351

Merged
merged 2 commits into from
May 5, 2022
Merged

Conversation

HimanshuM
Copy link
Contributor

This PR adds ability to add, modify or remove protocol mappers under a client scope in Keycloak.

@Nerzal
Copy link
Owner

Nerzal commented May 4, 2022

Hi!
Thank you for the contribution!

Could you please try and update your branch using the current main branch?
That should fix the CI Pipeline :)

@HimanshuM
Copy link
Contributor Author

Thanks for your response @Nerzal I have merged main into my fork.

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #351 (1636b01) into main (289eed6) will increase coverage by 0.07%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   76.78%   76.85%   +0.07%     
==========================================
  Files           4        4              
  Lines        1973     2005      +32     
==========================================
+ Hits         1515     1541      +26     
- Misses        317      320       +3     
- Partials      141      144       +3     
Impacted Files Coverage Δ
client.go 75.17% <81.25%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289eed6...1636b01. Read the comment docs.

Copy link
Owner

@Nerzal Nerzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for the contribution, now merging :)

I'll wait some more hours, before i create a new release, as we might get another PR merged today :)

@Nerzal Nerzal merged commit 47ca5d6 into Nerzal:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants