fix: prepend port with node name, to prevent "duplicate ports" error in multi-node clusters #410
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409.
When adding VLAN(s) to a broadcast domain, the broadcast domain will contain a list of ports added to it. In multi-node clusters, the same port/VLAN may exist on multiple nodes. With the current implementation, this will lead to the following error message:
This PR changes the code in a way that the port name is prefixed with the node name - in order to make the string values unique. This mimics the behavior of the CLI, which also prepends the node name to the port name in the output of
broadcast-domain show
.Acceptance tests (still) pass in my local test setup:
$ TF_ACC=1 go test ./internal/provider/networking/network_broadcast_domain_resource_test.go -v === RUN TestAccNetworkBroadcastDomainResource --- PASS: TestAccNetworkBroadcastDomainResource (3.72s) PASS ok command-line-arguments 3.731s