Randomize memory alignment and diagnose memory in benchmarks

NetFabric · May 2, 2024 · 19f3ff3 · 19f3ff3
1 parent 185a394
commit 19f3ff3
Show file tree

Hide file tree

Showing 20 changed files with 40 additions and 3 deletions.
diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/AddBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/AddBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class AddBenchmarks
 {
     short[]? sourceShort, otherShort, resultShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/AddMultiplyBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/AddMultiplyBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class AddMultiplyBenchmarks
 {
     short[]? sourceShort, otherShort, anotherShort, resultShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/AddValueBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/AddValueBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class AddValueBenchmarks
 {
     short[]? sourceShort, resultShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/CeilingBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/CeilingBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class CeilingBenchmarks
 {
     Half[]? sourceHalf, resultHalf;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/DegreesToRadiansBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/DegreesToRadiansBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class DegreesToRadiansBenchmarks
 {
     Half[]? sourceHalf, resultHalf;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/FirstGreaterThanBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/FirstGreaterThanBenchmarks.cs
@@ -6,6 +6,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class FirstGreaterThanBenchmarks
 {
     short[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/IndexOfFirstGreaterThanBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/IndexOfFirstGreaterThanBenchmarks.cs
@@ -6,6 +6,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class IndexOfFirstGreaterThanBenchmarks
 {
     short[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/IndexOfMinAggregateBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/IndexOfMinAggregateBenchmarks.cs
@@ -8,6 +8,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class IndexOfMinAggregateBenchmarks
 {
     short[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/MinAggregateBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/MinAggregateBenchmarks.cs
@@ -8,6 +8,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class MinAggregateBenchmarks
 {
     short[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/MinBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/MinBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class MinBenchmarks
 {
     short[]? sourceShort, otherShort, resultShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/MinMaxAggregateBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/MinMaxAggregateBenchmarks.cs
@@ -8,6 +8,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class MinMaxAggregateBenchmarks
 {
     short[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/NegateBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/NegateBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class NegateBenchmarks
 {
     short[]? sourceShort, resultShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/ProductBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/ProductBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class ProductBenchmarks
 {
     short[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/SinCosBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/SinCosBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class SinCosBenchmarks
 {
     Half[]? sourceHalf, sinResultHalf, cosResultHalf;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/Sum2DBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/Sum2DBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class Sum2DBenchmarks
 {
     MyVector2<short>[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/Sum3DBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/Sum3DBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class Sum3DBenchmarks
 {
     MyVector3<short>[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/Sum4DBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/Sum4DBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class Sum4DBenchmarks
 {
     MyVector4<short>[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/SumBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/SumBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class SumBenchmarks
 {
     short[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors.Benchmarks/SumNumberBenchmarks.cs b/src/NetFabric.Numerics.Tensors.Benchmarks/SumNumberBenchmarks.cs
@@ -7,6 +7,8 @@ namespace NetFabric.Numerics.Tensors.Benchmarks;
 [Config(typeof(VectorizationConfig))]
 [GroupBenchmarksBy(BenchmarkLogicalGroupRule.ByCategory)]
 [CategoriesColumn]
+[MemoryDiagnoser]
+[MemoryRandomization]
 public class SumNumberBenchmarks
 {
     short[]? arrayShort;

diff --git a/src/NetFabric.Numerics.Tensors/ApplyBinary.cs b/src/NetFabric.Numerics.Tensors/ApplyBinary.cs
@@ -68,16 +68,15 @@ public static void Apply<T1, T2, TResult, TOperator>(ReadOnlySpan<T1> x, ReadOnl
             ref var xVectorsRef = ref MemoryMarshal.GetReference(xVectors);
             ref var yVectorsRef = ref MemoryMarshal.GetReference(yVectors);
             ref var destinationVectorsRef = ref MemoryMarshal.GetReference(destinationVectors);
-            var indexVector = 0;
-            for (; indexVector < xVectors.Length; indexVector++)
+            for (var indexVector = 0; indexVector < xVectors.Length; indexVector++)
             {
                 Unsafe.Add(ref destinationVectorsRef, indexVector) = TOperator.Invoke(
                     ref Unsafe.Add(ref xVectorsRef, indexVector),
                     ref Unsafe.Add(ref yVectorsRef, indexVector));
             }
 
             // Update the index to the end of the last complete vector.
-            indexSource = indexVector * Vector<T1>.Count;
+            indexSource = xVectors.Length * Vector<T1>.Count;
         }
 
         // Iterate through the remaining elements.