Skip to content

Commit

Permalink
Remove the publish_nuget property from release build
Browse files Browse the repository at this point in the history
  • Loading branch information
jozefizso committed Dec 13, 2024
1 parent 0a33e70 commit 8202e96
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
11 changes: 0 additions & 11 deletions .github/Get-BuildInfo.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ function Write-GitHubVariable {
$app_version = $project.Project.PropertyGroup[0].NetOfficeRelease

$sign_binaries = 'false'
$publish_nuget = 'false'
$app_version_suffix = "preview${env:GITHUB_RUN_NUMBER}"

if ($configuration -ieq 'release') {
Expand All @@ -35,17 +34,8 @@ if ($configuration -ieq 'release') {
}

if ($ref -like 'refs/tags/v*') {
$publish_nuget = 'true'
$app_version_suffix = ''
}

if ($ref -like 'refs/heads/releases/*') {
$publish_nuget = 'true'
}

# if ($ref -like 'refs/heads/dev/github_actions') {
# $publish_nuget = 'true'
# }
}

$app_version_full = $app_version
Expand All @@ -57,4 +47,3 @@ Write-GitHubVariable "app_version" $app_version
Write-GitHubVariable "app_version_suffix" $app_version_suffix
Write-GitHubVariable "app_version_full" $app_version_full
Write-GitHubVariable "sign_binaries" $sign_binaries
Write-GitHubVariable "publish_nuget" $publish_nuget
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,13 @@ jobs:

- name: Pack NetOffice
id: packages
if: steps.build.outputs.publish_nuget == 'true'
run: |
dotnet pack --no-build --no-restore Source\NetOffice.sln -c ${{ env.Configuration }} -o dist
env:
VersionSuffix: ${{ steps.build.outputs.app_version_suffix }}

- name: Sign NetOffice packages
if: success() && steps.build.outputs.publish_nuget == 'true' && steps.build.outputs.sign_binaries == 'true'
if: success() && steps.build.outputs.sign_binaries == 'true'
run: |
$trustedsigning = Get-Content .\Source\trustedsigning.json | ConvertFrom-Json
Expand Down

0 comments on commit 8202e96

Please sign in to comment.