Skip to content

Commit

Permalink
Remove code signing from release action
Browse files Browse the repository at this point in the history
The Azure Trusted Signing service is still not yet supported by nuget tooling
  • Loading branch information
jozefizso committed Sep 29, 2024
1 parent b03e615 commit 91fa3d0
Showing 1 changed file with 1 addition and 36 deletions.
37 changes: 1 addition & 36 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ env:
RepositoryCommit: '${{ github.sha }}'

jobs:
build:

release:
runs-on: ubuntu-22.04

steps:
Expand Down Expand Up @@ -51,41 +50,7 @@ jobs:
${{ github.workspace }}/dist
${{ github.workspace }}/src/Kavod.Vba.Compression/README.md
sign:
needs: build
runs-on: windows-2022

steps:
- name: download artifact
uses: actions/download-artifact@v4
with:
name: VbaCompression_packages
path: ${{ github.workspace }}

- name: setup dotnet
uses: actions/setup-dotnet@v4
with:
dotnet-version: 6

- name: setup NuGetKeyVaultSignTool
run: dotnet tool install --verbosity minimal --global NuGetKeyVaultSignTool --version 3.2.3

- name: sign
id: sign_package
working-directory: '${{ github.workspace}}/dist'
run: |
NuGetKeyVaultSignTool.exe sign *.nupkg `
--file-digest sha256 `
--timestamp-rfc3161 http://timestamp.digicert.com `
--timestamp-digest sha256 `
--azure-key-vault-url "${{ secrets.KEYVAULT_URL }}" `
--azure-key-vault-tenant-id "${{ secrets.KEYVAULT_TENANT_ID }}" `
--azure-key-vault-client-id "${{ secrets.KEYVAULT_CLIENT_ID }}" `
--azure-key-vault-client-secret "${{ secrets.AZURESIGNTOOL_CLIENT_SECRET }}" `
--azure-key-vault-certificate "goITSolutions-until-2024-01"
- name: publish
if: ${{ steps.sign_package.outcome == 'success' }}
working-directory: '${{ github.workspace}}/dist'
run: |
dotnet nuget push "*.nupkg" --api-key $env:NUGET_PUSH_KEY --source https://api.nuget.org/v3/index.json
Expand Down

0 comments on commit 91fa3d0

Please sign in to comment.