Speedup reading file, added authenticode arg #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IO.File]::ReadAllBytes will place entire file in memory. On large files, this is a performance issue. Get-AuthenticodeStatus is extremely slow on large files. Added -SkipAuthenticode argument to skip checking authenticode.
aaronhudon
changed the title
|
I think it would be great if this got merged in...I just spent ...too long... trying to remember where I had seen something about skipping authenticode checks before (our usecase: because we want to combine everything else provided by Get-PESecurity with a direct call to Get-AuthentiCode signature to have access to more info than gets passed through Get-PESecurity) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IO.File]::ReadAllBytes will place entire file in memory. On large files, this is a performance issue.
Get-AuthenticodeStatus is extremely slow on large files. Added -SkipAuthenticode argument to skip checking authenticode.