Making gem thread safe (#549)

* Thread-safe gem

* Fixing small bugs to make tests pass

* Added test which confirms threaded behavior

Co-authored-by: Michael Bianco <iloveitaly@gmail.com>

lib/netsuite/configuration.rb

@@ -11,7 +11,7 @@ def reset!
  end
 
  def attributes
- @attributes ||= {}
+ Thread.current[:netsuite_gem_attributes] ||= {}
  end
 
  def connection(params={}, credentials={})
@@ -51,11 +51,11 @@ def filters=(list)
  end
 
  def wsdl_cache
- @wsdl_cache ||= {}
+ Thread.current[:netsuite_gem_wsdl_cache] ||= {}
  end
 
  def clear_wsdl_cache
- @wsdl_cache = {}
+ Thread.current[:netsuite_gem_wsdl_cache] = {}
  end
 
  def cached_wsdl

lib/netsuite/utilities.rb

@@ -7,11 +7,20 @@ module Utilities
  # TODO need structured logger for various statements
 
  def clear_cache!
- @netsuite_get_record_cache = {}
- @netsuite_find_record_cache = {}
+ Thread.current[:netsuite_gem_netsuite_get_record_cache] = {}
+ Thread.current[:netsuite_gem_netsuite_find_record_cache] = {}
+
  DataCenter.clear_cache!
  end
 
+ def netsuite_get_record_cache
+ Thread.current[:netsuite_gem_netsuite_get_record_cache] ||= {}
+ end
+
+ def netsuite_find_record_cache
+ Thread.current[:netsuite_gem_netsuite_find_record_cache] ||= {}
+ end
+
  def append_memo(ns_record, added_memo, opts = {})
  opts[:skip_if_exists] ||= false
 
@@ -194,11 +203,10 @@ def get_record(record_klass, id, opts = {})
  opts[:external_id] ||= false
 
  if opts[:cache]
- @netsuite_get_record_cache ||= {}
- @netsuite_get_record_cache[record_klass.to_s] ||= {}
+ netsuite_get_record_cache[record_klass.to_s] ||= {}
 
- if @netsuite_get_record_cache[record_klass.to_s].has_key?(id.to_i)
- return @netsuite_get_record_cache[record_klass.to_s][id.to_i]
+ if netsuite_get_record_cache[record_klass.to_s].has_key?(id.to_i)
+ return netsuite_get_record_cache[record_klass.to_s][id.to_i]
  end
  end
 
@@ -212,14 +220,14 @@ def get_record(record_klass, id, opts = {})
  end
 
  if opts[:cache]
- @netsuite_get_record_cache[record_klass.to_s][id.to_i] = ns_record
+ netsuite_get_record_cache[record_klass.to_s][id.to_i] = ns_record
  end
 
  return ns_record
  rescue ::NetSuite::RecordNotFound
  # log.warn("record not found", ns_record_type: record_klass.name, ns_record_id: id)
  if opts[:cache]
- @netsuite_get_record_cache[record_klass.to_s][id.to_i] = nil
+ netsuite_get_record_cache[record_klass.to_s][id.to_i] = nil
  end
 
  return nil
@@ -234,10 +242,8 @@ def find_record(record, names, opts = {})
  # FIXME: Records that have the same name but different types will break
  # the cache
  names.each do |name|
- @netsuite_find_record_cache ||= {}
-
- if @netsuite_find_record_cache.has_key?(name)
- return @netsuite_find_record_cache[name]
+ if netsuite_find_record_cache.has_key?(name)
+ return netsuite_find_record_cache[name]
  end
 
  # sniff for an email-like input; useful for employee/customer searches
@@ -263,7 +269,7 @@ def find_record(record, names, opts = {})
  }) }
 
  if search.results.first
- return @netsuite_find_record_cache[name] = search.results.first
+ return netsuite_find_record_cache[name] = search.results.first
  end
  end
 

spec/netsuite/configuration_spec.rb

@@ -14,6 +14,20 @@
  config.reset!
  expect(config.attributes).to be_empty
  end
+
+ it 'ensures that attributes are not shared between threads' do
+ config.attributes[:blah] = 'something'
+ expect(config.attributes[:blah]).to eq('something')
+
+ thread = Thread.new {
+ config.attributes[:blah] = 'something_else'
+ expect(config.attributes[:blah]).to eq('something_else')
+ }
+
+ thread.join
+
+ expect(config.attributes[:blah]).to eq('something')
+ end
  end
 
  describe '#filters' do