Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update savon and pray it doesn't break everything #172

Closed
wants to merge 1 commit into from
Closed

Update savon and pray it doesn't break everything #172

wants to merge 1 commit into from

Conversation

jcroteau
Copy link
Contributor

Update savon from ~> 2.3.0 to ~> 2.10.0 to resolve the following dependency conflicts with Rails 4.2

Bundler could not find compatible versions for gem "mime-types":
  In Gemfile:
    netsuite (>= 0) ruby depends on
      savon (~> 2.3.0) ruby depends on
        wasabi (~> 3.2.0) ruby depends on
          mime-types (< 2.0.0) ruby

    rails (= 4.2.0) ruby depends on
      actionmailer (= 4.2.0) ruby depends on
        mail (>= 2.5.4, ~> 2.5) ruby depends on
          mime-types (2.4.3)

Bundler could not find compatible versions for gem "nokogiri":
  In Gemfile:
    netsuite (>= 0) ruby depends on
      savon (~> 2.3.0) ruby depends on
        nokogiri (< 1.6, >= 1.4.0) ruby

    rails (= 4.2.0) ruby depends on
      actionmailer (= 4.2.0) ruby depends on
        rails-dom-testing (>= 1.0.5, ~> 1.0) ruby depends on
          nokogiri (1.6.6.2)

@iloveitaly
Copy link
Member

Haha love the title of this PR!

I've been testing out a newer version of Savon on this branch with a specific NetSuite integration project.

Have you encountered any issues with a newer savon version?

@greggroth Any experience with newer savon versions?

@jcroteau
Copy link
Contributor Author

@iloveitaly , I haven't experienced any problems thus far, but I'm only working with Customer search and delete_list actions at the moment.

@iloveitaly
Copy link
Member

Got it. Thanks for the info.

I want to be careful about this one: I'd like to hear back from some other users before merging this in.

Any thoughts on this @prburke?

@prburke
Copy link
Contributor

prburke commented Mar 20, 2015

@iloveitaly, I won't be able to give it a try until next week.

@rept
Copy link

rept commented Apr 15, 2015

Should this solve this problem as well?

Bundler could not find compatible versions for gem "savon":
  In Gemfile:
    netsuite (>= 0) ruby depends on
      savon (= 0.9.7) ruby

    valvat (>= 0) ruby depends on
      savon (2.4.0)

@rept
Copy link

rept commented Apr 15, 2015

Never mind, specifying git in gemfile fixed this.

gem 'netsuite', :git => 'git://github.com/NetSweet/netsuite.git'

@prburke
Copy link
Contributor

prburke commented May 1, 2015

@iloveitaly - I tried 2.10.0 and didn't see any issues 👍

@iloveitaly
Copy link
Member

This is finally merged into master! https://github.com/NetSweet/netsuite/releases/tag/0.5.0

@iloveitaly iloveitaly closed this Oct 19, 2015
@jcroteau
Copy link
Contributor Author

👍 👍 👍 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants