-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update list #376
base: master
Are you sure you want to change the base?
Add update list #376
Conversation
hash[:attributes!] ||= {} | ||
hash[:attributes!][kname] ||= {} | ||
hash[:attributes!][kname]['replaceAll'] = v.replace_all | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AgustinSuarez why did this functionality need to be moved out of the sublist module? I believe replaceAll
is only applicable to sublists, so I don't think it should be required anywhere else. What am I missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in order to upsert sales orders and other type of transaction correctly, you need to be able to define it as follows <listRel:addressbookList replaceAll="false"/>
The problem with the previous code is that it added it as a field and didn't take it into consideration.
This helps when upserting records like addresses and line items
@AgustinSuarez This looks great! I just left one comment in the code. Two other items that came to mind:
Thanks again! |
Hey @iloveitaly It's already rebased on master. I did on my machine and there are no changes done. I have also added the new documentation Thank you |
afd7f1a
to
e39f019
Compare
@iloveitaly My mistake. Had an issue with git. I have rebased on master. Thank you! |
7185ffc
to
df796ee
Compare
This PR allows sending references to other record type when using the initialize call. For example SO to Item Fulfillment, you can specify which ship group you want NS to return to you. Thats done via an aux_reference.
My mistake I also committed all those new changes in the same branch as the Update List PR that was done a couple months ago. That code remains unchanged.