Update customer record (update fields, add search only fields) #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scription to Subscription At least as far back as 2014.1, NetSuite used these names, without the Customer prefix, so this aligns the gems naming with NetSuite. This would be a breaking change for anyone using the old name.
The following were moved from `fields` to `record_refs`: - buying_reason - buying_time_frame - campaign_category - image - opening_balance_account - pref_cc_processor - representing_subsidiary - sales_group - sales_readiness The following were removed as `fields` since their sublist class is not yet implemented: - download_list - group_pricing_list - item_pricing_list I didn't update read-only fields as I don't trust NetSuite's documentation. They say `creditHoldOverride` is read-only, for example, but I can very clearly edit it. Therefore opting to leave this list as-is to avoid breaking changes.
cgunther
force-pushed
the
customer-search-only-fields
branch
from
15b0d98
to
def2636
Compare
|
I think 2014.1 isn't supported, so I'm fine merging this in. Thanks again for all of the great PRs1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the
onCreditHoldfield, which is only available via searches, so figured I'd add all the search only fields.Before adding all the search only fields, figured it was wise to update all the regular fields since search only fields often seem to be a superset of the regular fields. A few fields were corrected to be
record_refsand a few were removed as they require special sublist classes that aren't yet implemented.There is a breaking change here renaming
CustomerSubscriptionsListtoSubscriptionsListandCustomerSubscriptiontoSubscription. Looking at the schema for Customer, you'll see the type forsubscriptionsListisSubscriptionsList(no Customer prefix). This is true as far back as 2014.1 too. This break isn't strictly required, it could be removed from this PR, but seemed best to be consistent with NetSuite's record naming.