Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer support for external usages #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mandragora2
Copy link

No description provided.

"keywords" : ["netatmo", "api", "sdk"],
"homepage" : "https://dev.netatmo.com/",
"license": "MIT",
"minimum-stability": "stable",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can omit this property as this package does not have any dependency and the minimum-stability is only read from root packages (i.e packages that will require netatmo/netatmo-api)

@gruberro gruberro mentioned this pull request Jan 17, 2017
@XzAeRo
Copy link

XzAeRo commented Jan 17, 2017

Can I suggest the use of psr-4 instead of file autoloader?

{
  "autoload": {
    "psr-4":  {"Netatmo\\": "src/Netatmo"}
  }
}

This is more clean, and is up to the current standards.

@gruberro
Copy link

gruberro commented Jan 17, 2017

If you're searching for a quick solution I could offer you to use my up-to-date fork gruberro/Netatmo-API-PHP containing a composer.json (there might also be another fork out there having this done previously).

Simple add the following snippet to your composer.json.

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/gruberro/Netatmo-API-PHP"
    },
    ...
],
"require": {
    "netatmo/netatmo-api": "^2.0",
    ...
}

@tobiaskluge
Copy link
Contributor

Any news?

@winternet-studio
Copy link

Why is this not being merged in so that we can use the library like all other libraries? Any reason for making things more cumbersome than they need to be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants