Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run AC Tool in phase "INSTALLED" rather than "PREPARE" #287

Closed
kwin opened this issue Apr 30, 2018 · 4 comments · Fixed by #374
Closed

Allow to run AC Tool in phase "INSTALLED" rather than "PREPARE" #287

kwin opened this issue Apr 30, 2018 · 4 comments · Fixed by #374
Assignees
Milestone

Comments

@kwin
Copy link
Member

kwin commented Apr 30, 2018

Currently the install hook for applying the yaml files is being executed in Phase "Prepare" (https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/packaging/InstallContext.Phase.html). The reason for that is most probably due to the description in https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/packaging/InstallHook.html which states that only from Phase "Prepare" you can throw exceptions which lead to package installation failures.

The drawback of using PREPARE though is that

  1. you cannot create/update some initial content through a regular package structure and afterwards set ACLs for those in the same package.
  2. You cannot use repository structures as workaround for missing support for global variables (Allow to reuse variables from other YAML files #257)
  3. Initial content should be defined as regular content to be able to depend on it for application package type (https://issues.apache.org/jira/browse/JCRVLT-170). Those package types are not allowed to contain uncovered roots!

We should check again if PREPARE is really the only phase where Exception are being properly propagated.

@kwin
Copy link
Member Author

kwin commented Apr 30, 2018

@kwin
Copy link
Member Author

kwin commented Jun 28, 2018

https://issues.apache.org/jira/browse/JCRVLT-289 is fixed now and should be contained in the upcoming version 3.2 of Jackrabbit FileVault.

@kwin
Copy link
Member Author

kwin commented Nov 12, 2018

FileVault 3.2 is contained in AEM 6.4.2 or greater.

@kwin
Copy link
Member Author

kwin commented Oct 11, 2019

To still support older AEM versions, the default behaviour should stay as is, but optionally the hook should be executed in a different phase.

@kwin kwin self-assigned this Oct 11, 2019
kwin added a commit that referenced this issue Oct 11, 2019
upgrade bnd plugin to version 4.3.0
This closes #287
@kwin kwin added this to the 2.3.3 milestone Oct 11, 2019
kwin added a commit that referenced this issue Oct 11, 2019
upgrade bnd plugin to version 4.3.0
This closes #287
kwin added a commit that referenced this issue Oct 11, 2019
upgrade bnd plugin to version 4.3.0
This closes #287
kwin added a commit that referenced this issue Oct 11, 2019
upgrade bnd plugin to version 4.3.0
This closes #287
@ghenzler ghenzler removed this from the 2.3.3 milestone Nov 4, 2019
@kwin kwin added this to the 2.4.0 milestone Nov 12, 2019
@ghenzler ghenzler changed the title InstallHook should be executed in phase "INSTALLED" rather than "PREPARE" Allow to run AC Tool in phase "INSTALLED" rather than "PREPARE" Nov 12, 2019
@ghenzler ghenzler modified the milestones: 2.4.0, 2.4.1 Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants