-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to run AC Tool in phase "INSTALLED" rather than "PREPARE" #287
Comments
Even in the most recent version only PREPARE exceptions are properly propagated (https://github.com/apache/jackrabbit-filevault/blob/a64860257de2450f804b0cdf55a5afc8686b2636/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/InstallHookProcessorImpl.java#L150). I opened https://issues.apache.org/jira/browse/JCRVLT-289 for this. |
https://issues.apache.org/jira/browse/JCRVLT-289 is fixed now and should be contained in the upcoming version 3.2 of Jackrabbit FileVault. |
FileVault 3.2 is contained in AEM 6.4.2 or greater. |
To still support older AEM versions, the default behaviour should stay as is, but optionally the hook should be executed in a different phase. |
upgrade bnd plugin to version 4.3.0 This closes #287
upgrade bnd plugin to version 4.3.0 This closes #287
upgrade bnd plugin to version 4.3.0 This closes #287
upgrade bnd plugin to version 4.3.0 This closes #287
Currently the install hook for applying the yaml files is being executed in Phase "Prepare" (https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/packaging/InstallContext.Phase.html). The reason for that is most probably due to the description in https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/packaging/InstallHook.html which states that only from Phase "Prepare" you can throw exceptions which lead to package installation failures.
The drawback of using PREPARE though is that
We should check again if PREPARE is really the only phase where Exception are being properly propagated.
The text was updated successfully, but these errors were encountered: