Introduce retries when pinging servers. #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate the version response as opposed to logging and moving on.
jasonk000
reviewed
Dec 6, 2024
| } | ||
|
|
||
| if (i < maxRetries - 1) { | ||
| Thread.sleep(retryDelayMs); |
There was a problem hiding this comment.
This would block for 10 seconds per node during startup, which could be a very long time and would prevent application startup. I think we should aim to do this asynchronously or some other way.
There was a problem hiding this comment.
true, it can block for o(seconds). I've few more thoughts. I will share them shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate the version response as opposed to logging and moving on.