Merge pull request #665 from mattrjacobs/add-idempotent-concurrency-doc

Added comment to HystrixConcurrencyStrategy about non-idempotency of strategy application
Netflix · Feb 10, 2015 · 391cfd0 · 391cfd0
2 parents 7cfb1f9 + ec5750e
commit 391cfd0
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/...re/src/main/java/com/netflix/hystrix/strategy/concurrency/HystrixConcurrencyStrategy.java b/...re/src/main/java/com/netflix/hystrix/strategy/concurrency/HystrixConcurrencyStrategy.java
@@ -36,6 +36,10 @@
  * For example, every {@link Callable} executed by {@link HystrixCommand} will call {@link #wrapCallable(Callable)} to give a chance for custom implementations to decorate the {@link Callable} with
  * additional behavior.
  * <p>
+ * When you implement a concrete {@link HystrixConcurrencyStrategy}, you should make the strategy idempotent w.r.t ThreadLocals.
+ * Since the usage of threads by Hystrix is internal, Hystrix does not attempt to apply the strategy in an idempotent way.
+ * Instead, you should write your strategy to work idempotently. See https://github.com/Netflix/Hystrix/issues/351 for a more detailed discussion.
+ * <p>
  * See {@link HystrixPlugins} or the Hystrix GitHub Wiki for information on configuring plugins: <a
  * href="https://github.com/Netflix/Hystrix/wiki/Plugins">https://github.com/Netflix/Hystrix/wiki/Plugins</a>.
  */