Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hystrix threads are not daemon...cause hangs #759

Closed
cplee opened this issue Apr 16, 2015 · 1 comment
Closed

Hystrix threads are not daemon...cause hangs #759

cplee opened this issue Apr 16, 2015 · 1 comment

Comments

@cplee
Copy link
Contributor

cplee commented Apr 16, 2015

As pointed out in issue #102 the JVM hangs waiting for thread pool and timer threads to complete. As proposed in that issue, those threads ought to be set as daemon threads to avoid having to call Hystrix.reset()

I'd like to submit a pull request with these threads being set as daemon threads.
cplee added a commit to vspglobal/Hystrix that referenced this issue Apr 16, 2015
@cplee
set threads to daemon as per Netflix#759
2f0524b
cplee added a commit to vspglobal/Hystrix that referenced this issue Apr 16, 2015
@cplee
set threads to daemon as per issue Netflix#759
3b873c9
mattrjacobs added a commit that referenced this issue Apr 17, 2015
@mattrjacobs
Merge pull request #760 from vspglobal/issue-759
8c74e00 
set threads to daemon as per #759
@mattrjacobs
Copy link
Contributor

Merged in #760

@yanwork yanwork mentioned this issue Mar 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattrjacobs @cplee