Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model threadpool metrics as a stream #982

Closed
mattrjacobs opened this issue Nov 17, 2015 · 1 comment
Closed

Model threadpool metrics as a stream #982

mattrjacobs opened this issue Nov 17, 2015 · 1 comment

Comments

@mattrjacobs
Copy link
Contributor

See motivations in #943. This builds upon work in #981.

There are 2 types of threadpool metrics:

  1. Events - thread executed, thread rejected
  2. Utilization - only valid if sampled

We can recover the events from the Command stream in #981 by adding threadpool info to each event. This would allow us to avoid the cost of maintaining separate paths for writing these metrics.
#981 also provides the start of a first-class sample stream, which is a better way to model sampling-based metrics

@mattrjacobs
Copy link
Contributor Author

Done in #1047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant