Hystrix metrics as streams #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 12, 2016 14:52
… to RollingNumber/RollingPercentile as well)
* Added HystrixServoMetricsPublisherCommandTest as a concrete unit test that behavior is still correct
* They get calculated only on health count intervals
…el, to thread-level. * Added global-level stream as a way to recover command-level streams
… used for HystrixCommandMetrics
…command execution stream
…adpool-rejections
…hreadpools can both share them
… to thread pools as well
…e for event streams
added 9 commits
January 12, 2016 15:12
|
NetflixOSS » Hystrix » Hystrix-pull-requests #305 FAILURE |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #306 SUCCESS |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #307 FAILURE |
…be run concurrently
|
NetflixOSS » Hystrix » Hystrix-pull-requests #308 SUCCESS |
|
JMH comparison between 1.4.22 and this PR are here: https://docs.google.com/spreadsheets/d/1a0ERBQJZzlmVqMpuvvdSwbJuXwt0UmkPsFZ97pvgA8o/edit Highlights are:
|
mattrjacobs
added a commit
that referenced
this pull request
Jan 14, 2016
Hystrix metrics as streams
This was referenced Jan 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (large) set of commits is intended to solve #854 and #943.
The premise of these changes is that the Hystrix library is not the optimal place to decide how metrics should be consumed. By representing metrics as event streams, consumers gain flexibility in choosing their consumption strategy.
In 1.4.x, all events get aggregated in command-level data structures (
HystrixRollingNumberandHystrixRollingPercentile). This is lossy in the sense that only aggregate queries are possible against these data sources.At the moment, I've achieved feature and performance parity (AFAIK) with 1.4.x while ripping the usage of those data structures out. The metrics consumers that existed in 1.4.x are now wired against the new metrics streams. I haven't written new metrics streams that make better use of the new functionality, but that will be coming shortly.
I'm going to start a Wiki page with more details on the 1.5 metrics architecture. Will link that here when it's ready.
I've run this code in the Netflix production environment and haven't seen any show-stopping bugs, so this is very likely to become 1.5.0-RC1. When it does, I'd love feedback on design/usage. Any sort of code review would be much appreciated, as well.