Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using HystrixCollapser/reset-collapser #108

Merged
merged 1 commit into from
Feb 15, 2013
Merged

stop using HystrixCollapser/reset-collapser #108

merged 1 commit into from
Feb 15, 2013

Conversation

benjchristensen
Copy link
Contributor

See #106 and #102

@benjchristensen
Copy link
Contributor Author

@daveray is this a correct change to the clojure bindings?

The reasoning behind this is that resetting should only be done in dev and/or shutdown type scenarios, not part of production code flow.

The new Hystrix.reset() makes this more concrete and all individual reset() methods are package private.

@daveray
Copy link
Contributor

daveray commented Feb 15, 2013

Looks good.

benjchristensen added a commit that referenced this pull request Feb 15, 2013
stop using HystrixCollapser/reset-collapser
@benjchristensen benjchristensen merged commit 90d7713 into Netflix:master Feb 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants