Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed methods and variables with unused annotation #1154

Merged
merged 2 commits into from
Mar 21, 2016

Conversation

fcalderonnearsoft
Copy link
Contributor

I found more unused methods and variables related with #1150

@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #419 SUCCESS
This pull request looks good

@fcalderonnearsoft
Copy link
Contributor Author

Hi @mattrjacobs when you have time could you check this, please?

@@ -134,19 +134,6 @@ public boolean isRunning() {
/**
* Used to protect against leaking ExecutorServices and threads if this class is abandoned for GC without shutting down.
*/
@SuppressWarnings("unused")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one does get called, just not within the Hystrix library. See http://stackoverflow.com/questions/6872857/how-does-a-finalizer-guardian-work-in-java for a full explanation of how this works. This one should stay.

@mattrjacobs
Copy link
Contributor

@fcalderonnearsoft Sorry for the delay - was out on vacation for a few days. I left a note on the finalizer guardian, but the others look fine to remove. If you can re-add the finalizer guardian, I will merge the PR. Thanks for the contribution!

desc: re-add finalizerGuardian method
@fcalderonnearsoft
Copy link
Contributor Author

@mattrjacobs No problem, I already re-add finalizerguardian in a new commit.

Cheers.

@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #421 SUCCESS
This pull request looks good

mattrjacobs added a commit that referenced this pull request Mar 21, 2016
Removed methods and variables with unused annotation
@mattrjacobs mattrjacobs merged commit 66505b8 into Netflix:master Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants