Fix for IllegalStateException on Thread Rejection with Response Caching #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the additional logging I was able to write a unit test that replicated the issue and fix it. Rejected exceptions were not being handled correctly. #113
benjchristensen
added a commit
that referenced
this pull request
Feb 28, 2013
Fix for IllegalStateException on Thread Rejection with Response Caching
|
Hystrix-pull-requests #1 FAILURE |
|
Ignoring CloudBees for now ... some non-deterministic unit tests need to be fixed and CloudBees instances quite reliably cause issues whereas the Netflix Jenkins build never (or rarely) does. |
|
I let 2 instances run as production canaries for 24+ hours with higher than normal load (higher RPS driven by weighted-load-balancing being increased for these boxes) and didn't see any "Response Not Available" logs on either machine. I am going to proceed with releasing this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the additional logging I was able to write a unit test that replicated the issue and fix it.
Rejected exceptions were not being handled correctly.
#113