Set the thread pool size only when the configuration is changed. #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @yanglifan! I agree that the CI failure is unrelated. I'll merge in your PR and then get that unit test addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution will make Hystrix run faster in JDK 6. Since when create a
HystrixCommand,HystrixThreadPoolDefault.touchConfigwill be executed, then executeThreadPoolExecutor.setCorePoolSizeandThreadPoolExecutor.setMaximumPoolSize. These two methods will executemainLock.lock()all the time. That is negative to the performance.The improve is to check whether pool size will be changed or not before set this value.
This contribution will not affect JDK 7 and 8.