Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure thread-pools actually shutdown #1294

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

thesmith
Copy link
Contributor

When HystrixThreadPool.shutdown is called with a timeout, a single call to awaitTermination is called.
This is now done in a loop to make sure the thread-pool is definitely shutdown.

@thesmith
Copy link
Contributor Author

Hmmm.. that passes for me locally.

@mattrjacobs
Copy link
Contributor

I made an unrelated unit test that was intermittently failing less flaky, and Travis worked this time. Apologies for that.

Thanks for the commit

@mattrjacobs mattrjacobs merged commit da1198c into Netflix:master Aug 2, 2016
@thesmith thesmith deleted the shutdown_threadpools branch August 3, 2016 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants