Issue 1603 #1605
Merged
Issue 1603 #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
issue_1603
branch
3 times, most recently
from
de981fa
to
59aa32c
Compare
…d from an error to an empty value. This fixes Netflix#1603
|
Thanks @atoulme, unfortunately I'm not especially familiar with the Hystrix command state machine. It certainly seems like it's an invalid assumption that a command never unsubscribes before being run but hopefully someone that knows more can weigh in as well. @mattrjacobs? |
|
@atoulme Apologies for the delay in getting to this - I was out on vacation. I agree that your fix is correct. If the Nice find, and thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the observable value returned when the command was unsubscribed from an error to an empty value. This fixes #1603.