Osgi-ify hystrix-core, hystrix-examples #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hystrix-pull-requests #151 SUCCESS |
|
@benjchristensen I've attemtpted to OSGi'ify using my limited gradle knowledge. I've looked at the jar created in hystrix-core/build/hystrix-core-SNAPSHOT5.jar but don't see the archaius dependency compiled in. Nor do I know how to make sure that the rxjava dependency is either not compiled into the jar or is compiled in and exported out. |
What do you mean "compiled into the jar"? Are you expecting a far jar? If so why? Those dependencies would be resolved separately. |
|
The changes look correct so am merging. |
benjchristensen
added a commit
that referenced
this pull request
Dec 11, 2014
Osgi-ify hystrix-core, hystrix-examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed Ben's suggestions on how to add osgi manifest to hystrix. #309
[CONCERNS]
Some concerns I have is that the hystrix-core/build/libs/hystrix-core...jar doesn't contain the archaius dependencies. Is there something I should do to ensure these libs are compiled into the jar?