Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added thread pool metrics back to execution flow #367

Merged
merged 3 commits into from
Dec 17, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -515,12 +515,14 @@ public void call(Subscriber<? super R> s) {
} else {
// not timed out so execute
try {
threadPool.markThreadExecution();
final Action0 endCurrentThread = Hystrix.startCurrentThreadExecutingCommand(getCommandKey());
getExecutionObservable().doOnTerminate(new Action0() {

@Override
public void call() {
// TODO is this actually the end of the thread?
threadPool.markThreadCompletion();
executionHook.onThreadComplete(_self);
endCurrentThread.call();
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
package com.netflix.hystrix;

import org.junit.After;
import org.junit.Before;
import org.junit.Test;

import java.util.Collection;

import static org.junit.Assert.assertEquals;

/**
* Copyright 2013 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
public class HystrixThreadPoolMetricsTest {

@Before
public void resetAll() {
HystrixThreadPoolMetrics.reset();
}

@Test
public void shouldYieldNoExecutedTasksOnStartup() throws Exception {
//given
final Collection<HystrixThreadPoolMetrics> instances = HystrixThreadPoolMetrics.getInstances();

//then
assertEquals(0, instances.size());

}
@Test
public void shouldReturnOneExecutedTask() throws Exception {
//given
final Collection<HystrixThreadPoolMetrics> instances = HystrixThreadPoolMetrics.getInstances();

//when
new NoOpHystrixCommand().execute();

//then
assertEquals(1, instances.size());
assertEquals(1, instances.iterator().next().getRollingCountThreadsExecuted());
}

private static class NoOpHystrixCommand extends HystrixCommand<Void> {
public NoOpHystrixCommand() {
super(
Setter.withGroupKey(
HystrixCommandGroupKey.Factory.asKey("HystrixThreadPoolMetrics-UnitTest")));
}

@Override
protected Void run() throws Exception {
return null;
}
}


}