Unit tests for HystrixCommandExecutionHooks (Manual merge of #327) #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testExecutionHookFailedOnHystrixBadRequestWithSemaphoreIsolation
|
Hystrix-pull-requests #195 SUCCESS |
This was referenced Dec 27, 2014
mattrjacobs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual merge of #327. Thanks @krutsko for the contribution. The commits by @krutsko added unit tests demonstrating a number of failures of execution hooks.
onRunStartbeforeonThreadStart. This is now switched back toonThreadStartbeforeonRunStartonCompletehook twiceonThreadCompleteearlier, as the amount of logic executed on the Hystrix-isolated thread is less is 1.4. I'm opening issue Examine work performed on Hystrix-isolated thread #377 to check this out.onErrorexecution hook.