Add comprehensive hook tests #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 15, 2015 15:26
|
Hystrix-pull-requests #228 SUCCESS |
mattrjacobs
added a commit
that referenced
this pull request
Jan 16, 2015
Add comprehensive hook tests
mattrjacobs
added a commit
that referenced
this pull request
Jan 19, 2015
…k-tests Port of #520 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For addressing #509, I added comprehensive (I think) tests of all execution flows and what hooks get invoked on each. Out of this, I discovered #513, #514, #515, which will get addressed in separate PRs.
I will also be porting this test suite to master next, and hopefully uncovering the actual issue in #509 that I'm looking for.