Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove synchronous timeout #579

Merged

Conversation

mattrjacobs
Copy link
Contributor

This removes the synchronous timeout path entirely and relies solely on async timeouts coming from the HystrixTimer thread. Previously, calling HystrixCommand.execute() or .queue() would trigger the synchronous timeout.

Internal performance tests have indicated that performance is generally unchanged with this PR. I've also created a issue (#578) to track getting performance tests included as part of this project.

The benefits of this change are:

  1. Simplification
  2. Fixes Timeout mechanism doesn't work for command which is queued but not blocked upon #514
  3. Removes the code-path shown in the stack trace of Deadlock under "Fallback: Cache via Network" pattern #352 - so we know that there's at least one path through the synchronous timeout flow that's not thoroughly tested. Removing the synchronous timeout path entirely may fix this problem.

Matt Jacobs added 2 commits January 27, 2015 21:01
Conflicts:
	hystrix-core/src/main/java/com/netflix/hystrix/AbstractCommand.java
@cloudbees-pull-request-builder

Hystrix-pull-requests #250 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #11 SUCCESS
This pull request looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout mechanism doesn't work for command which is queued but not blocked upon
2 participants