Unit test demonstrating racy HystrixRequestLog #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NetflixOSS » Hystrix » Hystrix-pull-requests #150 FAILURE |
|
Actually, the initial test wasn't accurate. It was spinning up 5 Observables, then creating a merged Observable out of them. Given all 5 were throwing an Exception, the result of merge would also throw upon receipt of the first onError, possibly leaving the other 4 outstanding while the RequestLog was being queried. The next test is just starting a single command, awaiting it to throw and then checking the request log. I haven't seen this fail locally, so am waiting to see if I can reproduce it on Cloudbees/Travis |
|
NetflixOSS » Hystrix » Hystrix-pull-requests #151 SUCCESS |
mattrjacobs
added a commit
that referenced
this pull request
Aug 6, 2015
Unit test demonstrating racy HystrixRequestLog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates problem from #847